Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Invoice / Receipt pdf output: write it directly to the outputstream instead of keeping it in memory #578

Closed
syjer opened this issue Jan 12, 2019 · 1 comment
Closed

Invoice / Receipt pdf output: write it directly to the outputstream instead of keeping it in memory #578

syjer opened this issue Jan 12, 2019 · 1 comment
Assignees
@syjer
Labels
enhancement
Milestone
2.0-M1

Comments

@syjer
Copy link
Member

syjer commented Jan 12, 2019 •
edited
Loading

Currently in InvoiceReceiptController we keep the pdf in memory in a byte array and the call `FileUtil.sendPdf`` , we can improve the memory consumption by directly writing the pdf to the outputsream.

Note: most likely we have this issue in others places.
@syjer syjer added this to the 2.0-M1 milestone Jan 12, 2019
@syjer syjer self-assigned this Jan 12, 2019
syjer added a commit that referenced this issue Jan 12, 2019
@syjer
#578 don't keep in memory the receipt/invoice pdf in InvoiceReceiptCo…
c6d78f1 
…ntroller
@syjer
Copy link
Member Author

syjer commented Jan 12, 2019

should be fixed. Note: we can improve in more places!

@syjer syjer closed this as completed Jan 12, 2019
cbellone added a commit that referenced this issue Jan 12, 2019
@cbellone
#578 - backport to 2.0-M0
cd8d10d
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@syjer syjer

Labels
enhancement
Projects
None yet
Milestone
2.0-M1
Development

No branches or pull requests
1 participant
@syjer