Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

final work for public rest api #657

Closed
syjer opened this issue Jun 13, 2019 · 3 comments
Closed

final work for public rest api #657

syjer opened this issue Jun 13, 2019 · 3 comments

Comments

@syjer
Copy link
Member

syjer commented Jun 13, 2019

This issue will track the last items that need to be done for the public rest api integration.

  • ControllerExceptionHandler return a structured json result ? will be considered in another release if necessary
@syjer syjer added this to the 2.0-M2 milestone Jun 13, 2019
@syjer syjer self-assigned this Jun 13, 2019
@syjer syjer closed this as completed in 40da94d Jun 13, 2019
syjer added a commit that referenced this issue Jun 13, 2019
@syjer syjer reopened this Jun 13, 2019
syjer added a commit that referenced this issue Jun 14, 2019
syjer added a commit that referenced this issue Jun 14, 2019
syjer added a commit that referenced this issue Jun 14, 2019
syjer added a commit that referenced this issue Jun 14, 2019
syjer added a commit that referenced this issue Jun 19, 2019
syjer added a commit that referenced this issue Jun 19, 2019
cbellone pushed a commit that referenced this issue Jun 19, 2019
* initial work for goog analytics #657

* expose clientId (hashed session id if present) for goog analytics #657

* refactor: move anaylitcsconf in a separate file #657

* analytics conf: create factory method, expose in global alf.io info object too #657
syjer added a commit that referenced this issue Jun 19, 2019
@syjer
Copy link
Member Author

syjer commented Jun 19, 2019

Note:

for request context utils removal:
search for: @RequestParam(required = false, name = "lang") .

Wherever it's used, we should always do:

-> ticket locale (if present)
-> specified locale by the user if in event
-> reservation locale (if present)
-> a locale of the event as a ultimate fallback

This rule can be applied for:

  • generateTicketPdf ok
  • sendTicketByEmail ok
  • updateTicketInfo ok

Others:

  • (admin) confirmPayment -> as a fallback for ticket locale -> ok
  • reserveTicket -> for creating a new reservation -> client side ok
  • confirmOverview -> for payment specification -> client side ok
  • validateToOverview -> for updating reservation locale and as a fallback for ticket locale -> client side ok
  • reSendReservationConfirmationEmail -> use locale passed as parameter -> client side ok

Additionally, review all use of:

Locale.forLanguageTag
new Locale( -> convert where it makes sense to Locale.forLanguageTag

edit: add a check constraint for language to be set at reservation and ticket level if the email field is present. Note: add value if null in script! Will be done later.

Implement: LocaleUtil.forLanguageTag(String, Event)

syjer added a commit that referenced this issue Jun 20, 2019
syjer added a commit that referenced this issue Jun 26, 2019
syjer added a commit that referenced this issue Jun 26, 2019
cbellone pushed a commit that referenced this issue Jun 26, 2019
* #657 initial stubs for code-url feature

* #657 add redirect from old url to api handler

* port old event code handling code #657

* refactor: move createticketreservation in a separate method #657

* refactor: remove unused payment callback controller #657

* misc refactor: use try with resource

* misc cleanup: remove unused code

* #657 remove unused code

* #657 refactor createTicketReservation

* #657 fallback locale

* enable partially the {code} functionality #657

* for {code} functionality: enable the case: restricted category+url code: disabled call to TicketReservationManager.renewSpecialPrice in flow #657

* disable tests #657

* add integration test for {code} for hidden category #657

* integration test: special price repository: check count #657

* handle #671

* refactor: remove specialPriceSessionId parameter #657

* refactor: remove specialPriceSessionId parameter #657

* refactor: remove specialPriceSessionId parameter+misc conf manager #657

* remove use of special price session id in admin reservation manager #657

* add test for reservation for hidden category #657

* remove last piece of sessionId in special price #657

* refactor: switch from Integer to int for param #657

* select for update skip locked for special price #657

* return binding result #657

* {code} flow: add query string for errors #657

* {code} flow: add query string for errors #657

* update frontend #657

* update frontend #657
syjer added a commit that referenced this issue Jul 2, 2019
cbellone pushed a commit that referenced this issue Jul 3, 2019
* initial work for removing the paypal token from the session #657

* cleanup paypal manager: remove unused code #657

* remove use of session for paypal token #657

* handle payment token removal #657
syjer added a commit that referenced this issue Jul 21, 2019
syjer added a commit that referenced this issue Jul 23, 2019
syjer added a commit that referenced this issue Jul 23, 2019
syjer added a commit that referenced this issue Jul 24, 2019
syjer added a commit that referenced this issue Jul 31, 2019
syjer added a commit that referenced this issue Jul 31, 2019
syjer added a commit that referenced this issue Aug 1, 2019
@syjer
Copy link
Member Author

syjer commented Aug 1, 2019

can be considered done. If others issues will pop up, they will be handled in a separate issue.

@syjer syjer closed this as completed Aug 1, 2019
syjer added a commit that referenced this issue Aug 8, 2019
syjer added a commit that referenced this issue Aug 8, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant