Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add an unified "blob" cache #1366

Merged
merged 9 commits into from
Jul 12, 2024
Merged

add an unified "blob" cache #1366

merged 9 commits into from
Jul 12, 2024

Conversation

syjer
Copy link
Member

@syjer syjer commented Jun 30, 2024

with a configurable "directory", used by file upload, font and images for passkit.

@syjer syjer requested a review from cbellone June 30, 2024 18:51


public FileBlobCacheManager(Environment environment) {
this.cacheDir = Optional.ofNullable(environment.getProperty("alfio.cache-dir")).orElse(System.getProperty("java.io.tmpdir"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

if (Files.exists(resourcePath)) {
return resourcePath.toFile();
}
log.info("Cache not hit for file {}", id);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better log cache miss at DEBUG or TRACE level?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to debug

Copy link

@cbellone cbellone merged commit 727daa9 into main Jul 12, 2024
19 checks passed
@syjer syjer deleted the fileblob-cache branch September 26, 2024 09:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants