Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

add OpenShift README How To/YAML & .s2i/environment #524

Merged
merged 2 commits into from
Feb 7, 2019
Merged

add OpenShift README How To/YAML & .s2i/environment #524

merged 2 commits into from
Feb 7, 2019

Conversation

vorburger
Copy link
Contributor

see #403

@vorburger vorburger mentioned this pull request Oct 2, 2018
Closed
@vorburger
Copy link
Contributor Author

@cbellone @syjer perhaps you would like to (manually) test this? Just shout if NOK for you...

@coveralls
Copy link

coveralls commented Oct 2, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 51.383% when pulling dba1a76 on vorburger:openshift_1.x-maintenance-squash1 into 14cf513 on alfio-event:1.x-maintenance.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 51.543% when pulling c950df7 on vorburger:openshift_1.x-maintenance-squash1 into c505817 on alfio-event:1.x-maintenance.

@vorburger
Copy link
Contributor Author

@coveralls how can the coverage decrease if this adds no new code?! 😸

@cbellone @syjer perhaps you would like to make Coverall less picky and shut up for <1% ?

@vorburger vorburger mentioned this pull request Oct 3, 2018
Closed
@vorburger
Copy link
Contributor Author

@syjer @cbellone so how do you like this? Anything else I can do to get this PR merged?

cbellone
cbellone requested changes Oct 10, 2018
View reviewed changes
README.md Outdated
@@ -72,9 +72,36 @@ Importing the Gradle project into Intellij and Eclipse both work.

`./gradlew dependencyUpdates`


## Run on OpenShift
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to have this section in another tutorial or wiki page, as we don't have direct reference to other providers on the README.
However, we could add a section "How to run in production", linking the tutorials on the website. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I can move it out of the main README and just link to it. But I'm personally not a huge fan of keeping doc in a separate repo .. IMHO it's easier to have doc as an integral part of a PR together with code changes. I'm therefore going to propose a new docs/ folder here - hope you'll like that.

openshift.yaml Outdated
@@ -0,0 +1,196 @@
apiVersion: v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to move this in a subdirectory, like etc/openshift/ ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this file can be anywhere you like; I'll move it to etc/openshift/ as suggested.

@cbellone
Copy link
Member

Hi @vorburger, do you have time to apply the requested modification? It would be great to merge this PR!
Thanks

@vorburger
Copy link
Contributor Author

@cbellone yes! On my list, I'll see if I can make time for this afternoon...

@vorburger vorburger mentioned this pull request Feb 7, 2019
Closed
@vorburger
Copy link
Contributor Author

@cbellone I should have a moment today and tomorrow (but not next week) for this - shall we try to wrap it up and get it in? I'll rebase it and address your comments... just noticed that I did this for 1.x-maintenance.. do you still maintain that, or should I now make this for master instead?

@vorburger vorburger force-pushed the openshift_1.x-maintenance-squash1 branch from c950df7 to 3a95bd6 Compare February 7, 2019 13:58
@vorburger vorburger mentioned this pull request Feb 7, 2019
Open
@vorburger
Copy link
Contributor Author

do you still maintain that, or should I now make this for master instead?

actually that would take a little bit of work to adjust - how about first getting this finalized and into 1.x-maintenance, and then I'll (try to) follow up with a cherry-pick to master and the necessary adjustments?

@vorburger vorburger mentioned this pull request Feb 7, 2019
Closed
@vorburger
Copy link
Contributor Author

do you still maintain that, or should I now make this for master instead?

actually that would take a little bit of work to adjust - how about first getting this finalized and into 1.x-maintenance, and then I'll (try to) follow up with a cherry-pick to master and the necessary adjustments?

@cbellone
Copy link
Member

cbellone commented Feb 7, 2019

1.x-maintenance is the stable branch. We hope to release 2.0 by the end of this year, so we'll have plenty of time to update the tutorial :-)
RE: doc, I think it's OK, but then we'll have some documentation on the website and other content on the repo. I think that would be confusing for the users... WDYT?

@vorburger
Copy link
Contributor Author

vorburger commented Feb 7, 2019 •
edited
Loading

RE: doc, I think it's OK, but then we'll have some documentation on the website and other content on the repo. I think that would be confusing for the users... WDYT?

I find the doc on the web site is kind of hard to find.. I don't suppose it would help to convince you if I volunteered to "port" (copy/paste) the Cloud Foundry and Heroku doc into docs/deployment as well?

Otherwise if you feel strongly about this I guess I could also raise a PR against the alf.io-website instead; it's just that, as per alfio-event/alf.io-website#6, I really don't like having to write HTML for this :-(

What would you like me to do so that we can wrap up this PR?

@cbellone
Copy link
Member

cbellone commented Feb 7, 2019

I think we're OK here. And I also think that it doesn't make sense to duplicate content.
We can start a separate discussion (maybe on the mailing list?) about how to organize the documentation. I would be great if you could be part of that.

Can you raise a PR against the alf.io-website linking the tutorial on the homepage and on the "tutorials" menu?

@cbellone cbellone merged commit 8d92818 into alfio-event:1.x-maintenance Feb 7, 2019
vorburger added a commit to vorburger/alf.io-website that referenced this pull request Feb 7, 2019
@vorburger
replace (very, v1) old OpenShift with link to new one
2f92d51 
https://github.com/alfio-event/alf.io/blob/1.x-maintenance/docs/deployment/OpenShift.md

see alfio-event/alf.io#524
@vorburger vorburger mentioned this pull request Feb 7, 2019
Merged
@vorburger
Copy link
Contributor Author

I think we're OK here. And I also think that it doesn't make sense to duplicate content.
We can start a separate discussion (maybe on the mailing list?) about how to organize the documentation. I would be great if you could be part of that.

I would love to, but I probably won't have time, sorry...

Can you raise a PR against the alf.io-website linking the tutorial on the homepage and on the "tutorials" menu?

sure, see alfio-event/alf.io-website#7

@vorburger vorburger mentioned this pull request Feb 8, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cbellone cbellone cbellone requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vorburger @coveralls @cbellone