Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(specs): add acls to API endpoints #2604

Merged
merged 1 commit into from
Jan 25, 2024
Merged

feat(specs): add acls to API endpoints #2604

merged 1 commit into from
Jan 25, 2024

Conversation

alphonseb
Copy link
Contributor

🧭 What and Why

Adding the ACLs to the QS api endpoints spec. Reference is https://github.com/algolia/go/blob/master/cmd/query-suggestions/query-suggestions-api/service/service.go

@alphonseb alphonseb requested a review from a team as a code owner January 25, 2024 17:30
@netlify Netlify
Copy link

netlify bot commented Jan 25, 2024 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 6cbe4fd
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65b29aac9b3f110008704e23
😎 Deploy Preview https://deploy-preview-2604--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

millotp
millotp approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution !

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 25, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@millotp millotp changed the title feat(qs): add acls to API endpoints feat(specs): add acls to API endpoints Jan 25, 2024
@millotp millotp merged commit e569a3e into main Jan 25, 2024
27 of 28 checks passed
@millotp millotp deleted the feat/qs/new-acls branch January 25, 2024 18:29
@alphonseb alphonseb mentioned this pull request Jan 26, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@millotp millotp millotp approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

@shortcuts shortcuts Awaiting requested review from shortcuts shortcuts is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alphonseb @algolia-bot @millotp