Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(swift): appID casing #2711

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix(swift): appID casing #2711

merged 1 commit into from
Feb 15, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Feb 15, 2024

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

  • Fix casing

@Fluf22 Fluf22 self-assigned this Feb 15, 2024
@Fluf22 Fluf22 requested a review from a team as a code owner February 15, 2024 11:41
@netlify Netlify
Copy link

netlify bot commented Feb 15, 2024 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 3ac4248
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65cdf883c9655a0009c053b1
😎 Deploy Preview https://deploy-preview-2711--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 15, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

millotp
millotp reviewed Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use the same casing in other files too pls ?

millotp
millotp approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good sorry

@Fluf22 Fluf22 merged commit 785cd3d into main Feb 15, 2024
14 checks passed
@Fluf22 Fluf22 deleted the fix/swift-id-casing branch February 15, 2024 13:07
@Fluf22
Copy link
Contributor Author

Fluf22 commented Feb 15, 2024

Np bro

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fluf22 @algolia-bot @millotp