fix(swift): QuerySuggestionsConfigurationResponse appID casing #2712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
Fluf22
force-pushed
the
fix/swift-param-naming
branch
from
a9f6402
to
cb23483
Compare
Fluf22
force-pushed
the
fix/swift-param-naming
branch
from
cb23483
to
eab0fd5
Compare
millotp
reviewed
Feb 15, 2024
| @@ -122,6 +122,7 @@ public void processOpts() { | |||
| ); | |||
|
|
|||
| reservedWords.add("LogLevel"); | |||
| nameMapping.put("appId", "appID"); | |||
There was a problem hiding this comment.
does it make sense to have it only for appID ? maybe there are a lot more variable in the code with the same format (userID maybe ?)
Maybe there is a more global setting in openapi generator to change the casing for all variables ?
There was a problem hiding this comment.
I think we can adapt case by case, it's easy
millotp
approved these changes
Feb 16, 2024
millotp
reviewed
Feb 16, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
appIDcasing everywhere