Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(swift): have a codable body for improved ux #2902

Merged
merged 3 commits into from
Mar 25, 2024
Merged

fix(swift): have a codable body for improved ux #2902

merged 3 commits into from
Mar 25, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Mar 22, 2024 •
edited by jira bot
Loading

🧭 What and Why

🎟 JIRA Ticket: DI-1895

Changes included:

  • use Codable instead of a dictionary by default, so users can just put models

@Fluf22 Fluf22 self-assigned this Mar 22, 2024
@Fluf22 Fluf22 requested a review from a team as a code owner March 22, 2024 18:52
@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 22, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 22, 2024 •
edited
Loading

🚀 Deployed on https://660134dc7fedff8fe7543810--api-clients-automation.netlify.app

@github-actions github-actions bot temporarily deployed to pull request March 22, 2024 19:05 Inactive
millotp
millotp approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea what this does but gg !

@github-actions github-actions bot temporarily deployed to pull request March 25, 2024 08:05 Inactive
@Fluf22
Copy link
Contributor Author

Fluf22 commented Mar 25, 2024

Friendlier type 😁

@github-actions github-actions bot temporarily deployed to pull request March 25, 2024 08:25 Inactive
@Fluf22 Fluf22 merged commit cdac5ff into main Mar 25, 2024
25 checks passed
@Fluf22 Fluf22 deleted the fix/swift-codable-body branch March 25, 2024 08:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@millotp millotp millotp approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fluf22 @algolia-bot @millotp