fix(specs): add virtual index settings and update renderingContent #3254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
kai687
reviewed
Jun 25, 2024
Comment on lines
+67
to
+69
| virtual: | ||
| type: boolean | ||
| description: Only present if the index is a [virtual replica](https://www.algolia.com/doc/guides/managing-results/refine-results/sorting/how-to/sort-an-index-alphabetically/#virtual-replicas). |
There was a problem hiding this comment.
Where is this supposed to show up? I can't use it with setSettings and I don't see it in the response for a virtual replica with getSettings? Is this used somewhere?
There was a problem hiding this comment.
good point, fixed in #3255, it's actually only returned when fetching the index list
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2514
Changes included:
port latest changes from the js repository