Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(clients): add api key helper test #3338

Merged
merged 20 commits into from
Jul 18, 2024
Merged

feat(clients): add api key helper test #3338

merged 20 commits into from
Jul 18, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Jul 9, 2024

🧭 What and Why

🎟 JIRA Ticket: DI-2507

Changes included:

  • generate test for waitForApiKey helpers
  • handle expected null response
  • add ts mock server

@Fluf22 Fluf22 requested a review from a team as a code owner July 9, 2024 10:31
@Fluf22 Fluf22 self-assigned this Jul 9, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 9, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 207a3b249915eb36ffd3dd1a910087d55605cc69
🍃 Generated commit 0c2874d86329872045b1709609b460e4896f5c86
🌲 Generated branch generated/feat/api-key-e2e

@Fluf22 Fluf22 force-pushed the feat/api-key-e2e branch 7 times, most recently from d8a9ac3 to 48a59b0 Compare July 12, 2024 15:05
@millotp millotp changed the base branch from main to fix/go-opts-2 July 17, 2024 21:57
Copy link

github-actions bot commented Jul 17, 2024

millotp
millotp previously approved these changes Jul 17, 2024
Base automatically changed from fix/go-opts-2 to main July 18, 2024 07:36
@millotp millotp dismissed their stale review July 18, 2024 07:36

The base branch was changed.

@millotp millotp merged commit a68907d into main Jul 18, 2024
21 checks passed
@millotp millotp deleted the feat/api-key-e2e branch July 18, 2024 08:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants