Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(specs): add primary to get settings response #3415

Merged
merged 5 commits into from
Jul 25, 2024
Merged

fix(specs): add primary to get settings response #3415

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e2be30c
fix(specs): add primary to get settings response
kai687 Jul 24, 2024
331b419
Merge branch 'main' into fix/primary
kai687 Jul 24, 2024
8e7f974
fix: rename settingsResponse to indexSettings
kai687 Jul 25, 2024
c06aaac
Revert "fix: rename settingsResponse to indexSettings"
kai687 Jul 25, 2024
5331694
Merge branch 'main' into fix/primary
kai687 Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions specs/search/common/schemas/SettingsResponse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
settingsResponse:
shortcuts marked this conversation as resolved.
Show resolved Hide resolved
allOf:
- $ref: '../../../common/schemas/IndexSettings.yml#/indexSettings'
- $ref: '#/WithPrimary'

WithPrimary:
type: object
additionalProperties: false
properties:
primary:
type: string
description: |
Replica indices only: the name of the primary index for this replica.
2 changes: 1 addition & 1 deletion specs/search/paths/settings/settings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ get:
content:
application/json:
schema:
$ref: '../../../common/schemas/IndexSettings.yml#/indexSettings'
$ref: '../../common/schemas/SettingsResponse.yml#/settingsResponse'
'400':
$ref: '../../../common/responses/BadRequest.yml'
'402':
Expand Down
Loading