Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix for parsing type strings for tuples containing static arrays of tuples #13

Merged
merged 8 commits into from
Nov 29, 2022
Merged

Fix for parsing type strings for tuples containing static arrays of tuples #13

merged 8 commits into from
Nov 29, 2022

Conversation

ahangsu
Copy link
Contributor

@ahangsu ahangsu commented Nov 28, 2022

Fix #12

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2022 •
edited
Loading

Codecov Report

Merging #13 (1d1c5c2) into main (558c203) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   73.41%   73.66%   +0.24%     
==========================================
  Files           3        3              
  Lines         963      972       +9     
==========================================
+ Hits          707      716       +9     
  Misses        182      182              
  Partials       74       74
Impacted Files Coverage Δ
abi/type.go 92.85% <100.00%> (+0.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahangsu
Copy link
Contributor Author

ahangsu commented Nov 28, 2022 •
edited
Loading

seems that the CI codecov-upload is having some issue: codecov/codecov-action#598

need a few re-runs (3 times) to make codecov-upload work, flaky?

ahangsu
ahangsu commented Nov 28, 2022
View reviewed changes
ahangsu
ahangsu commented Nov 28, 2022
View reviewed changes
algochoi
algochoi reviewed Nov 28, 2022
View reviewed changes
Copy link

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ahangsu ahangsu merged commit 278bd82 into algorand:main Nov 29, 2022
@ahangsu ahangsu deleted the tuple-array-bug-fix branch November 29, 2022 16:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@algochoi algochoi algochoi left review comments

@bbroder-algo bbroder-algo bbroder-algo approved these changes

@michaeldiamant michaeldiamant Awaiting requested review from michaeldiamant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot parse type strings for tuples containing static arrays of tuples
4 participants
@ahangsu @codecov-commenter @algochoi @bbroder-algo