network: add initial support for latency tracking #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsachiherman
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3028 +/- ##
==========================================
+ Coverage 43.65% 43.67% +0.01%
==========================================
Files 391 391
Lines 86792 86750 -42
==========================================
- Hits 37890 37885 -5
+ Misses 42873 42833 -40
- Partials 6029 6032 +3
Continue to review full report at Codecov.
|
|
wsPeer already has |
Yes.. this is only a POC. Clearly we won't need to have both when the solution is ready. My goal here was just to do the minimum so that we could measure the connection timing and determine if that aligns with the latencies we're configuring in the Mainnet-model. |
ghost
approved these changes
Oct 19, 2021
onetechnical
pushed a commit
that referenced
this pull request
Oct 25, 2021
## Summary This PR adds the node ( both client and server ), the ability to measure the time it takes to establish an outgoing connection ( excluding the TCP connection time ). This duration is captured as the initial latency, which would need to get updated via a pingpong style logic. ## Test Plan - [x] Extend existing unit tests - [x] mainnet-model testing is needed as well to confirm correctness
Merged
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the node ( both client and server ), the ability to measure the time it takes to establish an outgoing connection ( excluding the TCP connection time ).
This duration is captured as the initial latency, which would need to get updated via a pingpong style logic.
Test Plan