Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tech Debt: Reduce number of dependencies. #4750

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

winder
Copy link
Contributor

@winder winder commented Nov 3, 2022

We don't need this tool and its dependencies.

@winder winder requested review from cce and Eric-Warehime November 3, 2022 20:30
@winder winder self-assigned this Nov 3, 2022
@winder winder changed the title Remove beeep dependency. Enhancement: Reduce number of dependencies. Nov 3, 2022
@winder winder changed the title Enhancement: Reduce number of dependencies. Tech Debt: Reduce number of dependencies. Nov 3, 2022
@winder winder requested a review from brianolson November 3, 2022 20:40
@winder winder marked this pull request as ready for review November 3, 2022 20:40
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #4750 (7040190) into master (4ac719a) will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4750      +/-   ##
==========================================
- Coverage   54.58%   54.39%   -0.19%     
==========================================
  Files         414      414              
  Lines       53517    53517              
==========================================
- Hits        29212    29112     -100     
- Misses      21875    21976     +101     
+ Partials     2430     2429       -1     
Impacted Files Coverage Δ
util/metrics/gauge.go 0.00% <0.00%> (-81.09%) ⬇️
crypto/hashes.go 26.82% <0.00%> (-24.40%) ⬇️
cmd/tealdbg/cdtdbg.go 67.05% <0.00%> (-15.30%) ⬇️
node/topAccountListener.go 64.78% <0.00%> (-7.05%) ⬇️
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
util/bloom/bloom.go 87.67% <0.00%> (-4.11%) ⬇️
data/transactions/logic/doc.go 57.69% <0.00%> (-3.85%) ⬇️
crypto/merklesignature/merkleSignatureScheme.go 63.30% <0.00%> (-3.67%) ⬇️
crypto/stateproof/verifier.go 78.94% <0.00%> (-3.51%) ⬇️
ledger/tracker.go 74.89% <0.00%> (-2.98%) ⬇️
... and 14 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy algorandskiy merged commit 855304e into algorand:master Nov 3, 2022
@winder winder deleted the will/remove-dep branch November 3, 2022 21:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants