chore: generalize persisted lists in ledger #5741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
force-pushed
the
pavel/lists
branch
from
96fedb9 to
666a012
Compare
jannotti
previously approved these changes
Sep 15, 2023
Codecov Report
@@ Coverage Diff @@
## master #5741 +/- ##
==========================================
- Coverage 55.57% 55.50% -0.08%
==========================================
Files 476 473 -3
Lines 66857 66675 -182
==========================================
- Hits 37156 37006 -150
+ Misses 27179 27159 -20
+ Partials 2522 2510 -12
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jasonpaulos
reviewed
Sep 15, 2023
cce
reviewed
Sep 15, 2023
cce
previously approved these changes
Sep 15, 2023
jasonpaulos
approved these changes
Sep 18, 2023
jannotti
approved these changes
Sep 18, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed copies of persisted*List that existed in ledger before generics.
Test Plan
Migrated unit tests