-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
p2p: http catchpoints support #5924
Merged
algorandskiy
merged 4 commits into
algorand:feature/p2p
from
algorandskiy:pavel/p2p-http-ledger-service
Feb 5, 2024
Merged
p2p: http catchpoints support #5924
algorandskiy
merged 4 commits into
algorand:feature/p2p
from
algorandskiy:pavel/p2p-http-ledger-service
Feb 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/p2p #5924 +/- ##
===============================================
+ Coverage 55.98% 56.06% +0.07%
===============================================
Files 482 482
Lines 68057 68108 +51
===============================================
+ Hits 38103 38186 +83
+ Misses 27347 27318 -29
+ Partials 2607 2604 -3 ☔ View full report in Codecov by Sentry. |
gmalouf
reviewed
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asked a few questions, okay with approving after get a response to those.
gmalouf
approved these changes
Feb 5, 2024
6 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
P2P HTTP support for ledger service:
GetHTTPRequestConnection
:StreamChainingHost
wrapper forlibp2p.host.Host
allows multiple stream handlers for the same protocol.IDTest Plan
Added unit test for fetcher, service and new p2p stream wrapper.