catchpoint: fix data files deletion in hot/cold dirs scenario

[algorandskiy]

Summary

Fixed bug with data files deletion when catchpoint tracker configured with hot / cold directories.

Test Plan

1. Extended TestCatchpointFirstStageInfoPruning to repro and fix
2. Checked all MakeCatchpointFilePath and makeCatchpointDataFilePath to ensure they are used with ct.dbDirectory and ct.tmpDir correspondingly.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.71%. Comparing base (98ac36a) to head (bfb7c76).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5963      +/-   ##
==========================================
+ Coverage   55.33%   55.71%   +0.38%     
==========================================
  Files         489      489              
  Lines       68112    68112              
==========================================
+ Hits        37691    37952     +261     
+ Misses      27833    27589     -244     
+ Partials     2588     2571      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gmalouf]

Left a few comments to discuss - high level just wanted a better walkthrough in there of the test approach.