Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

crypto: convert BatchVerifier to interface #5988

Merged
merged 1 commit into from
May 7, 2024

Conversation

cce
Copy link
Contributor

@cce cce commented May 1, 2024

Summary

This changes the BatchVerifier to be an interface type, with a cgoBatchVerifier implementation, with a goal towards enabling an alternate pure Go implementation later in a future PR.

Test Plan

Existing tests should pass.

@cce cce added the Enhancement label May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 56.14%. Comparing base (5f81b7b) to head (b9b8113).
Report is 3 commits behind head on master.

Files Patch % Lines
crypto/onetimesig.go 63.63% 3 Missing and 1 partial ⚠️
crypto/batchverifier.go 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5988      +/-   ##
==========================================
+ Coverage   52.42%   56.14%   +3.72%     
==========================================
  Files         482      482              
  Lines       67969    67992      +23     
==========================================
+ Hits        35630    38173    +2543     
+ Misses      29656    27224    -2432     
+ Partials     2683     2595      -88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy merged commit 6c91f52 into algorand:master May 7, 2024
18 of 19 checks passed
@cce cce deleted the batch-verify-interface branch May 8, 2024 14:06
@cce cce requested a review from jannotti May 8, 2024 14:06
PhearZero pushed a commit to PhearNet/crypto that referenced this pull request Jan 17, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants