Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tests: Fix flakey ECDSA testing #6005

Merged
merged 1 commit into from
May 30, 2024

Conversation

jasonpaulos
Copy link
Contributor

Summary

Fix flakey ECDSA testing, where a signature component had a leading zero byte, so big.Int.Bytes() produced a 31 byte slice.

The failing job: https://app.circleci.com/pipelines/github/algorand/go-algorand/18380/workflows/1d84e0b5-2ad9-4ac7-94cf-5c6315ac7138/jobs/272246

Test Plan

Test only fix

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.87%. Comparing base (2335b35) to head (59ad02b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6005      +/-   ##
==========================================
+ Coverage   55.86%   55.87%   +0.01%     
==========================================
  Files         481      481              
  Lines       68357    68357              
==========================================
+ Hits        38185    38193       +8     
+ Misses      27568    27563       -5     
+ Partials     2604     2601       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jasonpaulos jasonpaulos merged commit 2f852b7 into algorand:master May 30, 2024
19 checks passed
@jasonpaulos jasonpaulos deleted the fix-flakey-ecdsa-test branch May 30, 2024 15:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants