Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

txHandler: fixes to ERL resources management #6019

Merged

Conversation

algorandskiy
Copy link
Contributor

Summary

ERL's capguard was not disposed properly in some scenarios that leaded to under or over provisioned capacity.

Test Plan

Added a unit test.

@algorandskiy algorandskiy self-assigned this Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.97%. Comparing base (6c91f52) to head (45b899c).
Report is 19 commits behind head on master.

Files Patch % Lines
data/txHandler.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6019      +/-   ##
==========================================
+ Coverage   55.94%   55.97%   +0.02%     
==========================================
  Files         482      482              
  Lines       68310    68317       +7     
==========================================
+ Hits        38219    38242      +23     
+ Misses      27500    27485      -15     
+ Partials     2591     2590       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy merged commit 08575d7 into algorand:master Jun 7, 2024
19 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants