Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Infrastructure: Only package algosdk in setup.py #428

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Conversation

algochoi
Copy link
Contributor

@algochoi algochoi commented Dec 27, 2022

This PR fixes setup.py so only algosdk and its subdirectories are installed.

Locally tested:

  • Delete *.egg-info and build directories
  • Run pip install .
  • Check that only algosdk is included in the install in site-packages. tests and examples are no longer shipped with the installation, which may address Move/rename "tests" module #374 as well.

Closes #408

@algochoi algochoi marked this pull request as ready for review December 27, 2022 16:54
@algochoi algochoi requested a review from tzaffi December 27, 2022 17:48
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested py preparing requirements.txt files pointing to the following alternatives:

  • py-algorand-sdk@git+https://github.com/algorand/py-algorand-sdk@develop
  • py-algorand-sdk@git+https://github.com/algorand/py-algorand-sdk@package-algosdk

I confirmed that pip install -r on the second did not include tests under site-packages but the first DID.

BTW, neither includes the examples directory.

@algochoi algochoi merged commit 28e4cb1 into develop Dec 27, 2022
@algochoi algochoi deleted the package-algosdk branch December 27, 2022 19:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Releases: Source distribution bundles extraneous artifacts
2 participants