-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
allow app id to be none since it may be called during create #592
Conversation
54c2e37
to
32b5769
Compare
Good catch. The solution looks good but it'd be nice to see a regression test added to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. I'm expecting mypy
to flag the fact that app_id
could now be None
. So, I recommend changing its signature to:
app_id: Optional[Expr]
32b5769
to
81e1f03
Compare
looks good, I will approve after a test on app-id == None gets added |
also add a line in CHANGELOG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks right to me
Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
While answering a question in the forum, I realized I'd not considered the case where a MethodCall may be used to create an application.
Since the AVM doesn't like the manual setting of AppId 0, we should allow app_id to be None and prevent setting the app id field