Proposal to refactor examples name and exclude tests from being shipped. #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
reviewed
Dec 5, 2022
There was a problem hiding this comment.
Thanks for the explanation in #608 and for creating this PR to remedy the situation.
I wasn't aware that the examples folder was being installed as a standalone package -- I think this behavior is not intentional nor desired.
So instead of renaming, could we keep the folder as examples, but change setup.py to only include the pyteal package?
|
^ Up Jason's point, I think it would be nice to not involve too much change in package structure itself, but rather specifying the only package is under |
|
Sounds good. I'll modify this PR |
|
I can't merge this as I don't have write privileges |
jasonpaulos
approved these changes
Dec 8, 2022
This was referenced Dec 20, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.