-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Sourcemap templates #696
Sourcemap templates #696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sourcemapper was breaking on the compile step it uses to discover program counters when TMPL variables were used. This PR adds back the template substitution prior to compilation, using new zeroed typed definitions to substitute in for the templates for the purposes of PC collection.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one minor question, but mostly looks reasonable
Description
Sourcemapper was breaking on the compile step it uses to discover program counters when TMPL variables were used. This PR adds back the template substitution prior to compilation, using new zeroed typed definitions to substitute in for the templates for the purposes of PC collection.
Previous Behavior