Skip to content

Renamed some files to more acuratly represent what they are. #524

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Oct 21, 2018
Merged

Renamed some files to more acuratly represent what they are. #524

merged 3 commits into from
Oct 21, 2018

Conversation

Trashtalk217
Copy link
Contributor

@Trashtalk217 Trashtalk217 commented Oct 20, 2018

When I started making PR's I thought saying that I was programming in lisp was enough information. Now I now that I'm actually programming in Common Lisp and to be more precise I renamed a couple of things. I'm still using the lisp highlighter though.

Also fixed a big where the Common lisp implementation for the monte carlo integration didn't show up.

@Gathros Gathros added General Hacktoberfest The label for all Hacktoberfest related things! labels Oct 20, 2018
@leios
Copy link
Member

leios commented Oct 20, 2018

The lang is always the file extension. Is .clisp the file extension for list code? I thought it was still .lisp?

@Trashtalk217
Copy link
Contributor Author

Trashtalk217 commented Oct 21, 2018

You're right, it is indeed .lisp. So how about the book.jason. Should the "lang" also be the file extension.
EDIT: I've taken a look at other languages and asumed that "lang" in the book.jason also refers to the file extension.

Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one lisp flag. Outside of that, it looks good to go.

@@ -83,8 +83,8 @@ each point is tested to see whether it's in the circle or not:
[import:2-4, lang:"lisp"](code/racket/monte_carlo.rkt)
{% sample lang="scala" %}
[import:3-3, lang:"scala"](code/scala/monte_carlo.scala)
{% sample lang="lisp" %}
[import:3-5, lang:"lisp"](code/scala/monte-carlo.lisp)
{% sample lang="clisp" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one here, this should still be lisp

Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@leios leios merged commit 3e4c4f7 into algorithm-archivists:master Oct 21, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
General Hacktoberfest The label for all Hacktoberfest related things!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants