Add C# implementation for the approximate counting algorithm #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikac
reviewed
Oct 18, 2021
There was a problem hiding this comment.
I like the fact that there has been added documentation to each method but I'm wondering why XML docstrings wasn't used?
More examples of how to make these docstrings.
Amaras
added
the
Implementation
|
Hi, thanks for the review. I didn't use docstrings originally, as there was some discussion on whether we should use language specific documentation style comments at all, but I agree that it looks way better and it makes sense here imo. I also updated the error thresholds according to #901 and the output as per #913. |
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to run this is described in #846.