-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update pFL-Bench scripts and README for the appendix-included version #169
Conversation
…ndix-added; make the pFL-Bench directory name consistent with the paper link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see the inline comments
benchmark/pFL-Bench/README.md
Outdated
@@ -36,6 +36,13 @@ You can find the full scripts from the another [branch](https://github.com/aliba | |||
We put all the config yaml file in the directory `benchmark/pfl_bench/yaml_best_runs`. | |||
To reproduce the experiments with searched best configurations, you can run the experiment as the following example: | |||
``` | |||
## Pre-step-1: If you do not use our docker, please install Federated Scope according to the pre-steps | |||
# git clone https://github.com/alibaba/FederatedScope.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not be commented out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified accordingly.
benchmark/pFL-Bench/README.md
Outdated
# git clone https://github.com/alibaba/FederatedScope.git | ||
## Pre-step-2: follow https://github.com/alibaba/FederatedScope/blob/master/README.md to build the running environment | ||
## Pre-step-3: switch to the branch `feature/pFL_bench` if you want to run the codes with the version for paper's experiments. | ||
# git switch Feature/pfl_bench |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified accordingly.
…ndix-added; make the pFL-Bench directory name consistent with the paper link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
update the pFL-Bench scripts according to the paper versioned by appendix-added
make the pFL-Bench directory name consistent with the paper link