Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update pFL-Bench scripts and README for the appendix-included version #169

Merged
merged 2 commits into from
Jun 17, 2022

Conversation

yxdyc
Copy link
Collaborator

@yxdyc yxdyc commented Jun 17, 2022

  • update the pFL-Bench scripts according to the paper versioned by appendix-added

  • make the pFL-Bench directory name consistent with the paper link

…ndix-added;

make the pFL-Bench directory name consistent with the paper link
@yxdyc yxdyc requested review from xieyxclack and DavdGao June 17, 2022 03:28
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see the inline comments

@@ -36,6 +36,13 @@ You can find the full scripts from the another [branch](https://github.com/aliba
We put all the config yaml file in the directory `benchmark/pfl_bench/yaml_best_runs`.
To reproduce the experiments with searched best configurations, you can run the experiment as the following example:
```
## Pre-step-1: If you do not use our docker, please install Federated Scope according to the pre-steps
# git clone https://github.com/alibaba/FederatedScope.git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not be commented out

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified accordingly.

# git clone https://github.com/alibaba/FederatedScope.git
## Pre-step-2: follow https://github.com/alibaba/FederatedScope/blob/master/README.md to build the running environment
## Pre-step-3: switch to the branch `feature/pFL_bench` if you want to run the codes with the version for paper's experiments.
# git switch Feature/pfl_bench
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same as above

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified accordingly.

…ndix-added;

make the pFL-Bench directory name consistent with the paper link
Copy link
Collaborator

@xieyxclack xieyxclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xieyxclack xieyxclack merged commit bd44d3d into alibaba:master Jun 17, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants