Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bugfix for the invalid system metric names, via using worker-specific monitor #175

Merged
merged 4 commits into from
Jun 20, 2022

Conversation

yxdyc
Copy link
Collaborator

@yxdyc yxdyc commented Jun 20, 2022

Bugfix for the invalid system metric names, via using worker-specific monitor (issue #132).

(Note: the main changes are for monitor.py, server.py and client.py; other files are changed due to the linter)

yxdyc added 4 commits June 20, 2022 12:30
(Note: the main changes are for monitor.py, server.py and client.py;  other files are changed due to the linter)
…etric

# Conflicts:
#	benchmark/FedHPOB/fedhpob/config.py
#	benchmark/FedHPOB/fedhpob/utils/util.py
(Note: the main changes are for monitor.py, server.py and client.py;  other files are changed due to the linter)
(Note: the main changes are for monitor.py, server.py and client.py;  other files are changed due to the linter)
@yxdyc yxdyc changed the title Feature/fix sys metric Bugfix for the invalid system metric names, via using worker-specific monitor Jun 20, 2022
@yxdyc yxdyc added the bug Something isn't working label Jun 20, 2022
@yxdyc yxdyc requested review from xieyxclack and DavdGao June 20, 2022 07:49
Copy link
Collaborator

@xieyxclack xieyxclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, and maybe we should update the way of naming in our tutorial

@DavdGao DavdGao merged commit ca6ab96 into alibaba:master Jun 20, 2022
@xieyxclack xieyxclack linked an issue Jun 21, 2022 that may be closed by this pull request
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid system metric names
3 participants