Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[HotFix] Format code #207

Merged
merged 3 commits into from
Jul 6, 2022
Merged

[HotFix] Format code #207

merged 3 commits into from
Jul 6, 2022

Conversation

rayrayraykk
Copy link
Collaborator

@rayrayraykk rayrayraykk commented Jul 6, 2022

The old format script seems failed for some reason. So I re-format code with yapf by pre-commit run --all-files. There still some format issues detected by flake8, I will fix them in next PR. Besides, I will remove script/format.sh and enable pre-commits in unitest, please help me with this @DavdGao , thanks.

Ps: I remove isort temporarily for the conflicts with yapf in import.

@rayrayraykk rayrayraykk added the bug Something isn't working label Jul 6, 2022
@rayrayraykk rayrayraykk requested a review from joneswong July 6, 2022 05:21
Copy link
Collaborator

@joneswong joneswong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved!

@joneswong joneswong merged commit 8b0f945 into alibaba:master Jul 6, 2022
@rayrayraykk rayrayraykk deleted the format_code branch July 11, 2022 04:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants