Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bugfix for merge_data #385

Merged
merged 4 commits into from
Sep 28, 2022
Merged

bugfix for merge_data #385

merged 4 commits into from
Sep 28, 2022

Conversation

yxdyc
Copy link
Collaborator

@yxdyc yxdyc commented Sep 26, 2022

as the title said, the original version uses shallow copy of the data of client 1

@yxdyc yxdyc added the bug Something isn't working label Sep 26, 2022
xieyxclack
xieyxclack previously approved these changes Sep 26, 2022
Copy link
Collaborator

@xieyxclack xieyxclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xieyxclack xieyxclack merged commit c77ff11 into alibaba:master Sep 28, 2022
rayrayraykk added a commit to rayrayraykk/FederatedScope that referenced this pull request Oct 9, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants