Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix b-local dissim #463

Merged
merged 3 commits into from
Dec 8, 2022
Merged

fix b-local dissim #463

merged 3 commits into from
Dec 8, 2022

Conversation

rayrayraykk
Copy link
Collaborator

@rayrayraykk rayrayraykk commented Dec 7, 2022 •
edited
Loading

Changes

  1. fix b-local dissim
  2. Add L2 dissim
  3. Fix client-wise split not enabled

Set eval.monitoring=['blocal_dissim', 'l2_dissim'] to enable this feature

@rayrayraykk rayrayraykk added the bug Something isn't working label Dec 7, 2022
@rayrayraykk rayrayraykk requested a review from joneswong December 7, 2022 11:42
@rayrayraykk rayrayraykk linked an issue Dec 8, 2022 that may be closed by this pull request
Client-wise configurations are ignored #464
Closed
joneswong
joneswong approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@joneswong joneswong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I strongly suggest to keep each pr focusing on one purpose.

@joneswong joneswong merged commit e2ce0ce into alibaba:master Dec 8, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@joneswong joneswong joneswong approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client-wise configurations are ignored
2 participants
@rayrayraykk @joneswong