Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add protect method for feature order in fl-xgb #497
Add protect method for feature order in fl-xgb #497
Changes from 22 commits
0d47076
ef1c0cb
d93ba58
57c80b3
e870236
f3ccf5f
e1af4f4
a6c1a89
01326e8
fd38282
a1e05d9
159a6c6
76846a4
a14e73b
9876bd9
86225b2
92d3d03
c3b5653
d513855
6c02215
0623b71
0b1c600
0a6a265
3f156fd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For convenience, I also protected the label owner's feature order before. Actually, label owner does not need to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it need some more efforts to fix this issue such as modifying the split position accordingly, we can add TODO item here and fix it later