Enhanced monitor with system metrics logging and wandb support #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upload/download bytes, convergence rounds and time
…ed or normally terminated)
yxdyc
requested review from
joneswong,
Osier-Yi,
xieyxclack,
rayrayraykk and
DavdGao
rayrayraykk
reviewed
May 17, 2022
| ): | ||
| log_res_best[ | ||
| f"{final_type}/{inner_key}"] = inner_val | ||
| # log_res_best = {} |
There was a problem hiding this comment.
What are the commented codes for?
| except ImportError: | ||
| logger.error( | ||
| "cfg.wandb.use=True but not install the wandb package") | ||
| exit() |
There was a problem hiding this comment.
How about raising ValueError?
There was a problem hiding this comment.
If import wandb failed, the system will trigger ImportError
joneswong
approved these changes
May 23, 2022
This was referenced May 24, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced monitor with system metrics logging and wandb support: