对于PostgreSQL，传递了错误的connectTimeout

[xlofhappy]

在DruidAbstractDataSource中 的 createPhysicalConnection 方法中，
if (driver != null && "org.postgresql.Driver".equals(driver.getClass().getName())) {
if (connectTimeoutStr == null) {
connectTimeoutStr = Integer.toString(connectTimeout);
}
physicalConnectProperties.put("loginTimeout", connectTimeoutStr);

            if (socketTimeoutSr == null) {
                socketTimeoutSr = Integer.toString(socketTimeout);
            }
            physicalConnectProperties.put("socketTimeout", socketTimeoutSr);
        }

当数据库时 postgresql时，使用connectTimeout的值传递 loginTimeout 属性至 postgresql的Driver中，用以创建物理连接，但org.postgresql.Driver 中会将 loginTimeout认为是以秒单位，详见方法 Driver中的 private static long timeout(Properties props) 方法

[kimmking]

You are right, from the README.md, loginTimeout/connectTimeout/socketTimeout are three different options of pg driver in seconds.

https://github.com/pgjdbc/pgjdbc/blob/2b90ad04696324d107b65b085df4b1db8f6c162d/README.md
https://github.com/pgjdbc/pgjdbc/search?q=socketTimeout&type=

[kimmking]

there will be corrected by two steps:

• config three options with seconds in your application, and correct comments/docs in druid codes
• add a loginTimeout to set it and not use connectTimeout option

[wenshao]

https://github.com/alibaba/druid/releases/tag/1.2.16
问题已修复，请用新版本

[kuguobing]

DruidDataSource::init()

if (connectTimeout == 0) {
socketTimeout = DEFAULT_TIME_CONNECT_TIMEOUT_MILLIS;
}

这个怎么还没改？

[kimmking]

fixed now: 06b8ac1

[lizongbo]

请使用 1.2.21验证

[laojiongkim]

1.2.21,it happended again

[DerrickRoseCode]

1.2.21 我的报错也还在

[kimmking]

pg的什么版本驱动，我记得之前修复过这个问题。 DerrickRoseCode ***@***.***> 于2024年10月23日周三 11:43写道：

…

1.2.21 我的报错也还在 — Reply to this email directly, view it on GitHub <#5096 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGFEVBGK3SGOUDZWQHWOUDZ44LOJAVCNFSM6AAAAABQN3A3OWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZQG44TQOBXGA> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>