Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bug in RestoreVisitor.visit #4532

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

XenoAmess
Copy link
Contributor

No description provided.

@wenshao wenshao merged commit 3b65c2b into alibaba:master Sep 5, 2022
@wenshao wenshao added this to the 1.2.12 milestone Sep 5, 2022
@wenshao
Copy link
Member

wenshao commented Sep 10, 2022

https://github.com/alibaba/druid/releases/tag/1.2.12
druid-1.2.12版本已发布,请帮忙用新版本验证

@XenoAmess
Copy link
Contributor Author

XenoAmess commented Sep 10, 2022

https://github.com/alibaba/druid/releases/tag/1.2.12 druid-1.2.12版本已发布,请帮忙用新版本验证

@wenshao

总算开始修了吗

我再梳理个列表给你,你抽空把下一批标记bug的也修了

清理和优化的可以不管,bug的放着几个月,不合适。

@XenoAmess
Copy link
Contributor Author

XenoAmess commented Sep 10, 2022

@wenshao

https://github.com/alibaba/druid/pulls/XenoAmess

image

趁着放假你先把这几十个标了bug头的审了再说,其他的可以放一放

标了possible bug的是我看你java层写的不对,没看你整体设计,选看。

另外你别忘了fastjson那边还有几个问题 也过一下。逮住你上线一次不容易。

https://github.com/alibaba/fastjson/pulls/XenoAmess

另外后续能不能安排严格点的代码审核。

上头的人看见是阿里的库,就觉得是个好东西tmd天天逼我用,我也不是每次都能拦住,所以你能不能少整点低级bug给我这边……

1 << 40这种代码都能上库,审核人员建议加强下责任心吧只能说。

趁着假期赶紧把历史债务补一补,平时你说忙可以理解,假期有空了加把劲呗?

有啥问题随时评论/发邮件,我会盯着。

@KANLON
Copy link
Contributor

KANLON commented Oct 1, 2022

@wenshao

https://github.com/alibaba/druid/pulls/XenoAmess

image

趁着放假你先把这几十个标了bug头的审了再说,其他的可以放一放

标了possible bug的是我看你java层写的不对,没看你整体设计,选看。

另外你别忘了fastjson那边还有几个问题 也过一下。逮住你上线一次不容易。

https://github.com/alibaba/fastjson/pulls/XenoAmess

另外后续能不能安排严格点的代码审核。

上头的人看见是阿里的库,就觉得是个好东西tmd天天逼我用,我也不是每次都能拦住,所以你能不能少整点低级bug给我这边……

1 << 40这种代码都能上库,审核人员建议加强下责任心吧只能说。

趁着假期赶紧把历史债务补一补,平时你说忙可以理解,假期有空了加把劲呗?

有啥问题随时评论/发邮件,我会盯着。

@XenoAmess
哥,我看您提的bug都是比较有用的,但是刚刚看了一下您的pr好像目前很多都是跟master 冲突了,要不您拉一下最新的代码,然后重新提一下pr,这样官方好处理一下,这样方便协助druid的sql解析尽量完美些,这样就不用我们自己后面修改源码,后面直接使用最新的官方包就可以了

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants