serialize support Boolean isXX getter, fix issue #673

alibaba · Aug 26, 2022 · e7f63f5 · e7f63f5
1 parent 9834a39
commit e7f63f5
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 3 deletions.
diff --git a/core/src/main/java/com/alibaba/fastjson2/util/BeanUtils.java b/core/src/main/java/com/alibaba/fastjson2/util/BeanUtils.java
@@ -690,7 +690,7 @@ boolean record = isRecord(objectClass);
                 if (firstChar >= 'a' && firstChar <= 'z' && methodNameLength == 4) {
                     nameMatch = false;
                 }
-            } else if (returnClass == boolean.class) {
+            } else if (returnClass == boolean.class || returnClass == Boolean.class) {
                 nameMatch = methodNameLength > 2 && methodName.startsWith("is");
                 if (nameMatch) {
                     char firstChar = methodName.charAt(2);

diff --git a/core/src/test/java/com/alibaba/fastjson2/issues/Issue673.java b/core/src/test/java/com/alibaba/fastjson2/issues/Issue673.java
@@ -0,0 +1,27 @@
+package com.alibaba.fastjson2.issues;
+
+import com.alibaba.fastjson2.JSON;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class Issue673 {
+    @Test
+    public void test() throws Exception {
+        Bean bean = new Bean();
+        bean.value = true;
+        assertEquals("{\"value\":true}", JSON.toJSONString(bean));
+    }
+
+    public static class Bean {
+        private Boolean value;
+
+        public Boolean isValue() {
+            return value;
+        }
+
+        public void setValue(Boolean value) {
+            this.value = value;
+        }
+    }
+}
diff --git a/core/src/test/java/com/alibaba/fastjson2/v1issues/issue_1400/Issue1496.java b/core/src/test/java/com/alibaba/fastjson2/v1issues/issue_1400/Issue1496.java
@@ -13,7 +13,7 @@ public class Issue1496 {
     @Test
     public void test_for_issue() throws Exception {
         String json = JSON.toJSONString(SetupStatus.FINAL_TRAIL);
-        assertEquals("{\"canRefuse\":true,\"code\":3,\"name\":\"FINAL_TRAIL\",\"nameCn\":\"公益委员会/理事会/理事长审核\"}", json);
+        assertEquals("{\"canRefuse\":true,\"code\":3,\"first\":false,\"last\":false,\"name\":\"FINAL_TRAIL\",\"nameCn\":\"公益委员会/理事会/理事长审核\"}", json);
     }
 
     public interface ISetupStatusInfo {

diff --git a/fastjson1-compatible/src/test/java/com/alibaba/fastjson/issue_1400/Issue1496.java b/fastjson1-compatible/src/test/java/com/alibaba/fastjson/issue_1400/Issue1496.java
@@ -13,7 +13,7 @@ public class Issue1496 {
     @Test
     public void test_for_issue() throws Exception {
         String json = JSON.toJSONString(SetupStatus.FINAL_TRAIL);
-        assertEquals("{\"canRefuse\":true,\"code\":3,\"name\":\"FINAL_TRAIL\",\"nameCn\":\"公益委员会/理事会/理事长审核\"}", json);
+        assertEquals("{\"canRefuse\":true,\"code\":3,\"first\":false,\"last\":false,\"name\":\"FINAL_TRAIL\",\"nameCn\":\"公益委员会/理事会/理事长审核\"}", json);
     }
 
     public interface ISetupStatusInfo {