fix special charactor handle in ai-security-guard plugin #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1394 +/- ##
==========================================
+ Coverage 35.91% 43.57% +7.66%
==========================================
Files 69 76 +7
Lines 11576 12320 +744
==========================================
+ Hits 4157 5368 +1211
+ Misses 7104 6619 -485
- Partials 315 333 +18 |
johnlanni
changed the title
CH3CHO
reviewed
Oct 16, 2024
| @@ -106,7 +106,7 @@ func getSign(params map[string]string, secret string) string { | |||
| }) | |||
| canonicalStr := strings.Join(paramArray, "&") | |||
| signStr := "POST&%2F&" + urlEncoding(canonicalStr) | |||
| // proxywasm.LogInfo(signStr) | |||
| proxywasm.LogDebugf("String to sign is:" + signStr) | |||
There was a problem hiding this comment.
都LogDebugf，为啥不用%s？不用%s还不如直接LogDebug。。。
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
响应文本中有特殊字符时的处理有些问题，修复该问题
fixes #1394