Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix a bug of ip-restriction plugin #1422

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

sjtuzbk
Copy link
Collaborator

@sjtuzbk sjtuzbk commented Oct 22, 2024

Ⅰ. Describe what this PR did

fix a bug of ip-restriction plugin.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.58%. Comparing base (ef31e09) to head (4aa6169).
Report is 158 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1422      +/-   ##
==========================================
+ Coverage   35.91%   43.58%   +7.67%     
==========================================
  Files          69       76       +7     
  Lines       11576    12320     +744     
==========================================
+ Hits         4157     5370    +1213     
+ Misses       7104     6616     -488     
- Partials      315      334      +19     

see 69 files with indirect coverage changes

@CH3CHO CH3CHO merged commit 0d79386 into alibaba:main Oct 22, 2024
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants