feat: lint for iceworks-server #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orange-C
reviewed
Jul 12, 2019
| @@ -2,7 +2,7 @@ const { eslintTS, deepmerge } = require('@ice/spec'); | |||
|
|
|||
| module.exports = deepmerge(eslintTS, { | |||
| rules: { | |||
| // 禁止用var引入模块：取消 | |||
| "@typescript-eslint/no-var-requires": 0 | |||
| "@typescript-eslint/no-var-requires": 0, | |||
There was a problem hiding this comment.
啥意思？我觉得这些规则都比较明确，不需要再注释说明了。
你的意思是加上注释为什么 取消？
| const pages = await this.scanPages(this.path); | ||
| return _.orderBy(pages, 'name', 'asc'); | ||
| } | ||
|
|
||
| async getOne(): Promise<any> { } | ||
| public async getOne(): Promise<any> { } |
There was a problem hiding this comment.
这些空函数的意义是什么？如果业务没有需要可以删除吧，没必要为了加这个还改写规则
| @@ -1,3 +1,4 @@ | |||
| /* eslint no-eval: 0 */ | |||
Orange-C
approved these changes
Jul 15, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Notes
dist/to .eslintignore, this is the directory of the build results of typescript;class-methods-use-thisto warning, I think this is a very controversial rule,thisis not used in many controllers;/* eslint */to ignore some rules for file and// eslint-disable-linefor line, please check the specific scenario.