refactor: replace console with midway logger #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenbin92
reviewed
Jul 16, 2019
| const { componentName } = params; | ||
| const routerConfigAST = this.getRouterConfigAST(); | ||
| const data = await this.getAll(); | ||
| const data = await this.getAll(undefined, ctx); |
There was a problem hiding this comment.
- 看两处调用参数都是 undefined，在定义的时候可以不传？
- getAll 接口一般情况下应该也不会有参数的
There was a problem hiding this comment.
这里主要是为了保持接口的一致性，现在所有的 module.method 接受的参数都是:
methond: (params: any, ctx: IContext)
我觉得这个接口规则是好的，所以这里也就没有打破这个规则。
chenbin92
approved these changes
Jul 16, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
midway logger stores logs to local files and send logs to remote.