fix: get npm client from storage #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenbin92
reviewed
Jul 17, 2019
| @@ -186,7 +187,8 @@ export default class Dependency implements IDependencyModule { | |||
|
|
|||
| socket.emit('adapter.dependency.upgrade.data', i18n.format('baseAdapter.dependency.reset.startInstall', {packageName})); | |||
|
|
|||
| const childProcess = execa('npm', ['update', packageName, '--silent'], { | |||
| const npmClient = this.storage.get('npmClient'); | |||
chenbin92
reviewed
Jul 17, 2019
| @@ -0,0 +1,13 @@ | |||
| import { checkAliInternal } from 'ice-npm-utils'; | |||
|
|
|||
| const getStorageNpmClient = async (storage: any) => { | |||
There was a problem hiding this comment.
考虑在这里直接引入 storage 文件，不用在每个调用的地方都去传一遍？
chenbin92
approved these changes
Jul 17, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.