Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Iceworks cli/log install info #2653

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

chenbin92
Copy link
Collaborator

  • 在下载 iceworks-core 之后安装依赖可能非常慢,目前只打印了一个提示,给用户的感觉以为是卡死,因此输出安装的详细日志流

image

@chenbin92 chenbin92 changed the base branch from master to iceworks-cli/release-3.0.3 August 8, 2019 12:28
@chenbin92 chenbin92 self-assigned this Aug 8, 2019
@chenbin92 chenbin92 requested a review from alvinhui August 8, 2019 12:29
@imsobear
Copy link
Collaborator

#2672 看下用哪个,感觉不是 level 的问题而是 stdio 的问题

@chenbin92
Copy link
Collaborator Author

chenbin92 commented Aug 11, 2019

#2672 看下用哪个,感觉不是 level 的问题而是 stdio 的问题

  1. 这里是子进程衍生的子进程,即先执行 npm run start 然后在执行 npm install 的流数据如下,没有实时的进度条信息和数据,因此与 iceworks 那个终端的做法保持一致,通过 --loglevel = silly 进行输出

  2. 这里 stdio 设置为 pipe 即在子进程和父进程之间创建一个管道,可以同 subproces 进行监听数据流进行输出,如果设置为 stdio 为 inherit 则是通过 process 进行监听输出,个人理解这里是没有区别的

image

@imsobear imsobear merged commit d70214b into iceworks-cli/release-3.0.3 Aug 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the iceworks-cli/log-install-info branch August 12, 2019 02:15
alvinhui pushed a commit that referenced this pull request Aug 12, 2019
* chore: update version

* fix: exit process when installation dependencies fail (#2647)

* feat: output installation log (#2653)

* fix: use cnpm registry when install server deps (#2672)

* chore: add changelog
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants