Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Project Page: Use destructured variable from hooks and refactor reloadAdapter #2668

Merged
merged 3 commits into from
Aug 13, 2019
Merged

Project Page: Use destructured variable from hooks and refactor reloadAdapter #2668

merged 3 commits into from
Aug 13, 2019

Conversation

tanhengyeow
Copy link
Contributor

@tanhengyeow tanhengyeow commented Aug 9, 2019 •
edited
Loading

  1. The project variable is destructured from the useProject hooks as projectStore.dataSource. We can use this variable instead.

  2. We can refactor the reloadAdapter method to be placed inside useProject hooks. That way we don't need to access projectStore in packages/iceworks-client/src/pages/Project/index.js.

@tanhengyeow tanhengyeow changed the title Project Page: Use destructured variable from hooks Project Page: Use destructured variable from hooks and refactor reloadAdapter Aug 9, 2019
@weekly-digest weekly-digest bot mentioned this pull request Aug 11, 2019
Closed
@alvinhui alvinhui self-requested a review August 13, 2019 00:12
@alvinhui alvinhui assigned tanhengyeow and unassigned luhc228 Aug 13, 2019
@alvinhui alvinhui merged commit e489a57 into alibaba:iceworks/release-3.1.0 Aug 13, 2019
@weekly-digest weekly-digest bot mentioned this pull request Aug 18, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alvinhui alvinhui alvinhui approved these changes

Assignees

@tanhengyeow tanhengyeow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanhengyeow @alvinhui @luhc228