Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix apsara base field parse error and microsecond handling in Apsara log parser #1308

Merged
merged 9 commits into from
Jan 4, 2024

Conversation

quzard
Copy link
Collaborator

@quzard quzard commented Jan 3, 2024

The parser previously used microsecond incorrectly in the time cache. Now only the time in second is properly retrieved from the cache. And the microsecond part is always parsed from log timestamps.

Additionally, a bounds check has been added to prevent out-of-range array access, ensuring reliable operation.

yyuuttaaoo and others added 6 commits January 3, 2024 09:40
The parser previously used microsecond incorrectly in the time
cache. Now only the time in second is properly retrieved from the
cache. And the microsecond part is always parsed from log timestamps.

Additionally, a bounds check has been added to prevent out-of-range array access,
ensuring reliable operation.
@quzard quzard changed the title fix apsara base field parse error fix apsara base field parse error and microsecond handling in Apsara log parser Jan 3, 2024
@quzard quzard changed the title fix apsara base field parse error and microsecond handling in Apsara log parser Fix apsara base field parse error and microsecond handling in Apsara log parser Jan 3, 2024
Copy link
Collaborator

@yyuuttaaoo yyuuttaaoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yyuuttaaoo yyuuttaaoo added the bug Something isn't working label Jan 4, 2024
@yyuuttaaoo yyuuttaaoo added this to the v2.0 milestone Jan 4, 2024
@yyuuttaaoo yyuuttaaoo merged commit d895044 into alibaba:main Jan 4, 2024
16 checks passed
@quzard quzard deleted the fix-apsara-base-field branch February 28, 2024 02:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants