fix: Ensure alarms raised during collection for profile projects are reported #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messixukejia
approved these changes
Apr 18, 2024
yyuuttaaoo
approved these changes
Apr 18, 2024
yyuuttaaoo
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alarms generated by the collector during the data collection process for profile
projects were previously not reported due to a rule designed to prevent circular
reporting of alarms. This rule intended to avoid alarms raised as a result
of attempting to send alarms to the profile project. However, it inadvertently
blocked genuine alarms that occurred during the direct collection to the profile
project itself. This fix adjusts the rule to differentiate between circular
alarms and legitimate collection errors, allowing the latter to be reported
as expected.