Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Parameter check is invalid in 2.4.0 and 2.4.1 #12563

Closed
KomachiSion opened this issue Aug 28, 2024 · 0 comments · Fixed by #12564
Closed

Parameter check is invalid in 2.4.0 and 2.4.1 #12563

KomachiSion opened this issue Aug 28, 2024 · 0 comments · Fixed by #12564
Assignees
@KomachiSion
Labels
kind/bug Category issues or prs related to bug.
Milestone
2.4.2

Comments

@KomachiSion
Copy link
Collaborator

Describe the bug
Parameter checker is added in 2.3.0, when refactor for request context, I make a mistake to change the ParamCheckerFilter configuration and make the ParamCheckerFilter name is conflict with other filter, so that the ParamCheckerFilter invalid.

Expected behavior
parameter invalid like groupName AAA*AA will be checked and return 400.

Actually behavior
request can be passed.

Desktop (please complete the following information):

  • Version 2.4.0 and 2.4.1
@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Aug 28, 2024
@KomachiSion KomachiSion added this to the 2.4.2 milestone Aug 28, 2024
@KomachiSion KomachiSion self-assigned this Aug 28, 2024
@KomachiSion KomachiSion mentioned this issue Aug 28, 2024
Merged
5 tasks
KomachiSion added a commit to KomachiSion/nacos that referenced this issue Sep 2, 2024
@KomachiSion
Addition fix alibaba#12563, Add parameter check for tag.
9778110
@KomachiSion KomachiSion mentioned this issue Sep 2, 2024
Merged
5 tasks
KomachiSion added a commit that referenced this issue Sep 2, 2024
@KomachiSion
Addition fix #12563, Add parameter check for tag. (#12575)
197347f
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@KomachiSion KomachiSion

Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
2.4.2
Development

Successfully merging a pull request may close this issue.

[ISSUE#12563] Fix paramchecker invalid bug KomachiSion/nacos
1 participant
@KomachiSion