Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix default sql in the comment to be consistent with the implementation #12324

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

Sitosoym
Copy link
Contributor

@Sitosoym Sitosoym commented Jul 9, 2024

Please do not create a Pull Request without creating an issue first.
按文档指示,该修改是小型修改,无需创建对应issue

What is the purpose of the change

修改mapper接口当中过时的注释内容,以使得注释中的sql内容和默认mysql实现类中的一致。
否则自己扩展datasource插件的时候,很容易被过时的注释混淆,导致连接其他数据库时的行为和期望行为不一致。

Brief changelog

增加注释中缺少的LIMIT字段,删除多余的字段等。

Verifying this change

修改注释后,注释中的sql内容和默认mysql当中实现的一致。

@KomachiSion KomachiSion reopened this Jul 18, 2024
@KomachiSion
Copy link
Collaborator

reopen pr to redo CICD.

@KomachiSion KomachiSion merged commit 3e28b58 into alibaba:develop Jul 24, 2024
9 of 13 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants