Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ISSUE#12446] getMacInstance 补充日志 #12447

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Conversation

fuhouyu
Copy link
Contributor

@fuhouyu fuhouyu commented Jul 31, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fixes #12446
对Mac getMacInstance(Key key)补充日志

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

头一次尝试着学习提交PR~如有规范和其它问题,希望大佬们提点,谢谢。

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2024

CLA assistant check
All committers have signed the CLA.

@HMYDK
Copy link
Contributor

HMYDK commented Jul 31, 2024

@fuhouyu pr中要关联issue,可以参考其它pr的书写方式。

@fuhouyu fuhouyu changed the title [ISSUE #12446] getMacInstance 补充日志 fix(#12446) getMacInstance 补充日志 Jul 31, 2024
@fuhouyu fuhouyu changed the title fix(#12446) getMacInstance 补充日志 Fixes(#12446) getMacInstance 补充日志 Jul 31, 2024
@fuhouyu fuhouyu changed the title Fixes(#12446) getMacInstance 补充日志 Fixes #12446 getMacInstance 补充日志 Jul 31, 2024
@fuhouyu fuhouyu changed the title Fixes #12446 getMacInstance 补充日志 [ISSUE#12446] getMacInstance 补充日志 Jul 31, 2024
@fuhouyu
Copy link
Contributor Author

fuhouyu commented Jul 31, 2024

@fuhouyu pr中要关联issue,可以参考其它pr的书写方式。

好的老师,已经修改,多谢指正。

@KomachiSion KomachiSion merged commit 4e42fe6 into alibaba:develop Aug 1, 2024
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mac getMacInstance(Key key)补充日志
4 participants