Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Log in to the console through a browser http://ip:8848/nacos and be redirected to the login page without pop-ups. (related issue #11153) #12907

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

littlesparklet
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

To solve this problem that log in to the console through a browser http://ip:8848/nacos and be redirected to the login page withpop-ups. (related issue #11153)

Copy link

github-actions bot commented Dec 2, 2024

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.25%. Comparing base (2a0dafa) to head (23cf467).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #12907   +/-   ##
==========================================
  Coverage      72.25%   72.25%           
  Complexity      9826     9826           
==========================================
  Files           1287     1287           
  Lines          41445    41445           
  Branches        4373     4373           
==========================================
+ Hits           29947    29948    +1     
+ Misses          9396     9394    -2     
- Partials        2102     2103    +1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a0dafa...23cf467. Read the comment docs.

@wuyfee
Copy link

wuyfee commented Dec 2, 2024

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@KomachiSion KomachiSion merged commit 52c661b into alibaba:develop Dec 4, 2024
8 checks passed
@KomachiSion KomachiSion added area/Nacos console Related to Nacos consle kind/enhancement Category issues or prs related to enhancement. labels Dec 4, 2024
@KomachiSion KomachiSion added this to the 2.5.0 milestone Dec 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/Nacos console Related to Nacos consle kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants