Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ISSUE #12962]Feat develop 3.0 dlock #12981

Merged
merged 16 commits into from
Jan 2, 2025

Conversation

shalk
Copy link
Contributor

@shalk shalk commented Dec 23, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

#12962

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@shalk shalk changed the title Feat develop 3.0 dlock [ISSUE #12962]Feat develop 3.0 dlock Dec 23, 2024
@shalk shalk marked this pull request as ready for review December 26, 2024 11:24
@KomachiSion KomachiSion merged commit cd7de01 into alibaba:v3.0-develop Jan 2, 2025
1 check passed
@KomachiSion KomachiSion added kind/feature type/feature Nacos3.0 Nacos 3.0 Architecture Evolution labels Jan 2, 2025
@KomachiSion KomachiSion added this to the 3.0.0 milestone Jan 2, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/feature type/feature Nacos3.0 Nacos 3.0 Architecture Evolution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants